Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont free the kb_path twice. #499

Merged
merged 1 commit into from
May 17, 2021

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented May 14, 2021

What:
Dont free the kb_path twice.

Why:
The functions calling g_strdup (kb_path) already take care of free()'ing the string, as well as delete once the kb is deleted.

How:
Kill redis and call openvas in the console.

$ openvas
(process:26189): GLib-WARNING (recursed) **: Invalid UTF-8 passed to g_io_channel_write_chars().Aborted

You can run valgrind openvas and check it.

Checklist:

The functions calling g_strdup (kb_path) already take care of free()'ing the string, as well as delete once the kb is deleted.
@jjnicola jjnicola requested a review from a team as a code owner May 14, 2021 14:34
@jjnicola jjnicola added the backport-to-main This pull request will be ported to the master branch label May 14, 2021
@jjnicola
Copy link
Member Author

Fix greenbone/openvas-scanner#733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-main This pull request will be ported to the master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants