Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate sentry #502

Merged
merged 10 commits into from
May 19, 2021
Merged

Integrate sentry #502

merged 10 commits into from
May 19, 2021

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented May 18, 2021 •
edited
Loading

What:
Integrate sentry

Why:

How:
Set the environment variable BUILD_SENTRY=1 before running cmake.
BUILD_SENTRY=1 cmake -DCMAKE_INSTALL_PREFIX=$INSTALL_PREFIX ..

sentry must be installed in the same install prefix, so cmake can use findpackage for sentry

Checklist:

@jjnicola jjnicola marked this pull request as ready for review May 18, 2021 11:13
@jjnicola jjnicola requested a review from a team May 18, 2021 11:13
@jjnicola jjnicola mentioned this pull request May 18, 2021
Merged
2 tasks
timopollmeier
timopollmeier requested changes May 18, 2021
View reviewed changes
timopollmeier
timopollmeier reviewed May 18, 2021
View reviewed changes
@jjnicola
Fix requested changes.
dc06f26 
- Log all critical messages
- reset sentry init flag
- Fix Cmake
@jjnicola jjnicola requested a review from timopollmeier May 18, 2021 15:15
timopollmeier
timopollmeier reviewed May 19, 2021
View reviewed changes
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would also be nice to have a function to check if gvm-libs is compiled with Sentry support or not.

@jjnicola jjnicola requested a review from timopollmeier May 19, 2021 07:44
@jjnicola jjnicola merged commit a3698bd into greenbone:master May 19, 2021
@jjnicola jjnicola deleted the sentry branch May 19, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjnicola @timopollmeier