Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate a hash value for a given string. #753

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Generate a hash value for a given string. #753

merged 3 commits into from
Apr 5, 2023

Conversation

jhelmold
Copy link
Member

@jhelmold jhelmold commented Apr 5, 2023

What

Implemented a function that generates a hash value for an arbitrary string.

Why

This function is needed for GEA-51 to catch duplicated results in reports.

References

Addresses GEA-51.

Checklist

  • Tests

@jhelmold
Generate a hash value for a given string.
ea9038c 
Implemented a function that generates a hash value for an
arbitrary string.
@jhelmold jhelmold requested a review from a team as a code owner April 5, 2023 07:23
@jhelmold jhelmold enabled auto-merge April 5, 2023 07:33
@jhelmold jhelmold added the backport-to-stable This pull request will be backported to the 21.04 branch label Apr 5, 2023
timopollmeier
timopollmeier requested changes Apr 5, 2023
View reviewed changes
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be more obvious what kind of hash is calculated (MD5) and how it is encoded.

util/authutils.c Outdated Show resolved Hide resolved
util/authutils.h Outdated Show resolved Hide resolved
util/authutils.c Outdated Show resolved Hide resolved
util/authutils.c Outdated Show resolved Hide resolved
@jhelmold jhelmold merged commit 2d1464a into greenbone:main Apr 5, 2023
@mergify mergify bot mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

Assignees
No one assigned
Labels
backport-to-stable This pull request will be backported to the 21.04 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhelmold @timopollmeier