Add: gvm_hosts_allowed_only() #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
added a commit
to greenbone/openvas-scanner
that referenced
this pull request
May 11, 2023
This PR fix an issue which produces the scan to be interrupted, because the denied hosts are not removed from the hosts list, and the final host count doesn't match with the amount of alive hosts. This ends with an interrupted scan produced by a wrong scan progress calculation. These fix depends on PR greenbone/gvm-libs#771. However, it is not a breaking change, since a pre-processor directive check for a flag. Without an updated gvm-libs behaves as before and uses the feature (the fix) if enabled. Jira SC-837
2 tasks
jjnicola
force-pushed
the
deny-hosts
branch
2 times, most recently
from
5f11a63 to
4814444
Compare
jjnicola
added a commit
to greenbone/openvas-scanner
that referenced
this pull request
May 11, 2023
This PR fix an issue which produces the scan to be interrupted, because the denied hosts are not removed from the hosts list, and the final host count doesn't match with the amount of alive hosts. This ends with an interrupted scan produced by a wrong scan progress calculation. These fix depends on PR greenbone/gvm-libs#771. However, it is not a breaking change, since a pre-processor directive check for a flag. Without an updated gvm-libs behaves as before and uses the feature (the fix) if enabled. Jira SC-837
This function removes denied hosts and kept the allowed hosts from the hosts list. For backward compatibility, a preprocesor directive defines a flag which enabled this feature.
Kraemii
approved these changes
May 15, 2023
jjnicola
added a commit
to greenbone/openvas-scanner
that referenced
this pull request
May 15, 2023
This PR fix an issue which produces the scan to be interrupted, because the denied hosts are not removed from the hosts list, and the final host count doesn't match with the amount of alive hosts. This ends with an interrupted scan produced by a wrong scan progress calculation. These fix depends on PR greenbone/gvm-libs#771. However, it is not a breaking change, since a pre-processor directive check for a flag. Without an updated gvm-libs behaves as before and uses the feature (the fix) if enabled. Jira SC-837
Kraemii
pushed a commit
to greenbone/openvas-scanner
that referenced
this pull request
May 23, 2023
This PR fix an issue which produces the scan to be interrupted, because the denied hosts are not removed from the hosts list, and the final host count doesn't match with the amount of alive hosts. This ends with an interrupted scan produced by a wrong scan progress calculation. These fix depends on PR greenbone/gvm-libs#771. However, it is not a breaking change, since a pre-processor directive check for a flag. Without an updated gvm-libs behaves as before and uses the feature (the fix) if enabled. Jira SC-837
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add: gvm_hosts_allowed_only()
Jira: SC-837
Used in: greenbone/openvas-scanner#1420
Why
This function removes denied hosts and kept the allowed hosts from the hosts list.
For backward compatibility, a pre-procesor directive defines a flag which enabled this feature.
References
Checklist