Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: missing dependency in container prod-testing #806

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Jan 19, 2024

What

Add: missing dependency in container prod-testing

Why

libhiredis-dev is missing

References

Checklist

  • Tests

@jjnicola jjnicola requested review from a team as code owners January 19, 2024 13:28
@jjnicola jjnicola merged commit 597fd78 into main Jan 22, 2024
10 checks passed
@jjnicola jjnicola deleted the docker-prod-testing-dep branch January 22, 2024 07:03
@bjoernricks
Copy link
Contributor

Sorry but why is a dev dependency missing in a production container?

@y0urself
Copy link
Member

y0urself commented Oct 8, 2024

btw.: I want to also ask the question from @bjoernricks ... why is there a dev dependency missing in the production image?
This should be added to build time not to the run time of the container ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants