Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the list of current Local Security Checks for the Auto-FP feature #1054

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Updated the list of current Local Security Checks for the Auto-FP feature #1054

merged 3 commits into from
Apr 21, 2020

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Apr 21, 2020

This updates the hard-coded list of Local Security Checks used by the Auto-FP to the current used Local Security Checks families. The "Privilege escalation" family was misplaces in the list and was removed as well.

Checklist:

@mattmundell
Copy link
Contributor

Could you give some explanation of why Privilege Escalation is no longer needed?

I'm pretty sure I was explicitly asked to include it when I added the feature, but I don't know why it was required.

@cfi-gb
Copy link
Member Author

cfi-gb commented Apr 21, 2020

"Privilege escalation" isn't a "LSC checks only" category like all others families existing in that list.

There might be a few LSCs placed in this "Privilege escalation" but if this is a criterion then we basically would need to add most of the other existing families to this list as well.

@mattmundell mattmundell merged commit a07e416 into greenbone:master Apr 21, 2020
@cfi-gb cfi-gb deleted the update_lsc_family_list branch April 21, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants