Simplify sync lockfile handling #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option will be used to change the path to the feed lock file
These functions use the path set with --feed-lock-path and also write and clear the contents of the file.
The functions update_secinfo and rebuild_scap now use these and the timestamp no longer has to be set in update_scap and update_cert.
This is no longer needed with the common lockfile for all sync operations.
It is no longer needed because the lockfile is now cleared as part of the unlocking.
They are no longer used in sync_cert, sync_scap and update_scap as the feed_lockfile_lock calls will handle writing the timestamp.
The scripts now use GVM_FEED_LOCK_PATH set by CMake and are configurable by setting the LOCK_PATH environment variable.
manage_update_nvt_cache_osp and manage_rebuild now also use this file and the messages have been adjusted.
This was referenced Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various sync actions will now use a common, configurable lockfile and
some of the lock handling code for syncs in gvmd has been simplified.
Checklist: