Reduce the memory cache of NVTs #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only used in minor places, like creating a fake result for TEST_ALERT.
This is not really related to the result iterator.
This only uses an nvti internally, so shouldn't look like an nvti API.
This is about a GMP NVT, not an nvti.
mattmundell
changed the title
This is for GET_AGGREGATES, used by the word count graph.
timopollmeier
approved these changes
May 19, 2020
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size of the internal NVTi cache.
The only data now cached is the NVT references. These are used by the result lists and the SecInfo GET commands. While it would be OK to use queries for the SecInfo case, It is not so easy to integrate the refs into the result iterator (because there are many refs per result). A better approach may be to adjust GMP to not send the NVT details/refs with each result, but somehow separately.
Checklist: