Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync SCAP using a second schema #1111

Merged
merged 29 commits into from
Jun 3, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented May 28, 2020

This changes the SCAP sync to:

  • create a second schema "scap2", and to replace "scap" with scap2 once scap2 is ready.
  • always build the entire scap db from scratch.
  • load the SCAP from CSV files in the feed, if such files exist.

Benefits:

  • simpler sync code
  • avoid slow queries required to find CVEs and CPEs that have been removed from the feed
  • solves problem of entries changing in feed without associated modification time change (eg if there was an error in the feed entry)
  • loading from CSV is faster (1m vs 6min)
  • CSV loading opens the way for us to move all the sync calculations out of gvmd.

Checklist:

Sorry, something went wrong.

@mattmundell mattmundell marked this pull request as ready for review June 1, 2020 15:30

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@timopollmeier timopollmeier merged commit f55cd1b into greenbone:master Jun 3, 2020
@mattmundell mattmundell deleted the bg-scap-sync branch June 10, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants