Drop GMP scanners

[mattmundell]

What:

Remove support for GMP scanners. This is the old "slave" feature where a gvmd controls another gvmd using GMP.

From the GMP doc compatibility change:

The scanner type "GMP" has been removed. This is the original "slave"
feature, where a gvmd (the master) controls another gvmd (the slave)
via GMP.

Existing GMP scanners are automatically migrated to type "OpenVAS".
The "OpenVAS" scanner type uses the OSP protocol, and is better suited
to the master-slave scenario.

CREATE_SCANNER and MODIFY_SCANNER no longer accept type "4".

In the report XML, as returned by GET_REPORTS, SLAVE has been removed
from REPORT/TASK.

All other scanner related commands work as before, but there are no
GMP scanners for them to work with.

Why:

• The newer OSP scanners provide a better way to do this.
• Reduces the amount of code to maintain.

How:

These gvmd commands should now fail:

• gvmd --slave-commit-size=1000
• gvmd --create-scanner=test2 --scanner-type=GMP --scanner-host=/path/to/test.sock --scanner-ca-pub=/path/to/cacert.pem --scanner-key-pub=/path/to/clientcert.pem --scanner-key-priv=/path/to/clientkey.pem
• gvmd --create-scanner=test2 --scanner-type=4 --scanner-host=/path/to/test.sock --scanner-ca-pub=/path/to/cacert.pem --scanner-key-pub=/path/to/clientcert.pem --scanner-key-priv=/path/to/clientkey.pem
• gvmd --modify-scanner=<UUID> --scanner-type=GMP
• gvmd --modify-scanner=<UUID> --scanner-type=4

These GMP commands should fail:

• <modify_scanner scanner_id="a22be4dd-17d5-44c0-9f76-92c21ecc2105"><type>gmp</type></modify_scanner>
• <modify_scanner scanner_id="a22be4dd-17d5-44c0-9f76-92c21ecc2105"><type>4</type></modify_scanner>
• <create_scanner><name>test</name><host>127.0.0.1</host><port>1</port><type>gmp</type></create_scanner>
• <create_scanner><name>test</name><host>127.0.0.1</host><port>1</port><type>4</type></create_scanner>

Checklist:

• Tests
• CHANGELOG Entry

[BasvanH]

You cant have more than one NVT scanner and OSP does not support NVT. Whats the new way of creating more NVT scan capacity?

[mattmundell]

You cant have more than one NVT scanner and OSP does not support NVT. Whats the new way of creating more NVT scan capacity?

You can have more than one "NVT scanner". It's not possible to create them in GSA yet, but via GMP either copy OpenVAS Default:

<create_scanner><copy>08b69003-5fc2-4037-a479-93b440211c73</copy></create_scanner>

or create one from scratch

<create_scanner><name>osp-openvas from scratch</name><type>2</type><host>127.0.0.1</host><port>9392</port></create_scanner>
gvmd --modify-scanner UUID --scanner-host=/path/to/ospd-openvas.sock