Fix alternative options for radio type preferences when exporting a scan config #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmundell
requested changes
Aug 31, 2020
| @@ -8674,13 +8674,6 @@ buffer_config_preference_xml (GString *buffer, iterator_t *prefs, | |||
| char *pos = strchr (value, ';'); | |||
| if (pos) *pos = '\0'; | |||
| buffer_xml_append_printf (buffer, "<value>%s</value>", value); | |||
| while (pos) | |||
There was a problem hiding this comment.
Surely this hasn't been broken since 2010? I think this worked because OTP sent the alts with the value. Has ospd-openvas stopped doing that?
There was a problem hiding this comment.
Hmm, I think somewhere along the line we lost track of keeping the alts in the preference value in the XML. For example in the feed config XML one radio value includes the alts but the other one does not.
And gvmd was not checking for the alts when importing XML configs, so the values ended up in dbs without alts. My current db has both.
I think using using default_value which comes from the nvts table is a good solution.
mattmundell
approved these changes
Aug 31, 2020
This was referenced Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add alternative option for radio type nvt's preferences
Why:
When exporting, the alternative options were not added to the xml file.
How:
Importing a scan config and checking the NVT's preferences, search for an radio type pref. Only the default value was shown. Now the alternative values are shown as well.
Checklist: