Add permission check on host in OS host count #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timopollmeier
requested changes
Sep 29, 2020
There was a problem hiding this comment.
This seems to work for the most part but it seems to break the "Operating Systems by Vulnerability Score" chart for me.
I think it's probably because the replacement of the extra WITH clause by extra_tables isn't applied (correctly) to the get_aggregates command.
Should work now. |
timopollmeier
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add a permission check on the hosts in the host count of the OS asset iterator.
Why:
The count was including hosts that the user did not have access to.
How:
Scan a new host with a new OS with user 1.
Scan same host with user 2.
Check GSA > Assets > OSs: count should be 1 not 2.
Checklist: