Delete TLS certificate sources when deleting users #1334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The delete_tls_certificates_user function now also removes the referenced
rows from tls_certificate_sources, tls_certificate_locations and
tls_certificate_origins.
Why:
This caused foreign key constraint violations when deleting a user owning
any TLS certificates.
How:
Tested this by creating a new user, importing a report with TLS certificates and then trying to delete the user without an inheritor.
With the patch this should work, whereas it caused an error like this before:
Checklist: