Delete report format dirs last when deleting a user

[mattmundell]

What:

When deleting a user, to avoid having to roll back the movement of the report format dirs, delete the dirs absolutely last. That is, delete dirs after all SQL has run, in case any of that SQL fails.

Why:

Errors in the SQL were leaving the report format dirs in an inconsistent state.

How did you test it:

1. gvmd --create-user=webadmin --password=w --role=Admin
2. as feed owner, delete 5 report formats, empty trashcan
3. gvmd --modify-setting 78eceaec-3385-11ea-b237-28d24461215b --value UUID_OF_webadmin (set feed owner to webadmin)
4. create table refs (id SERIAL PRIMARY KEY, owner integer REFERENCES users (id) ON DELETE RESTRICT);
5. insert into refs (owner) values ((select id from users where name = 'webadmin'));
6. ls var/lib/gvm/gvmd/report_formats/ => 5 files
7. gvmd --delete-user=webadmin --inheritor=user2 (should fail due to refs)
8. ls var/lib/gvm/gvmd/report_formats/ => still 5 files
9. gvmd --delete-user=webadmin (should fail due to refs)
10. ls var/lib/gvm/gvmd/report_formats/ => still 5 files
11. delete from refs;
12. repeat 7 or 9, should pass.

Checklist:

• Tests
• CHANGELOG Entry