Update report run status more consistently #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure the task status changes in fork_osp_scan_handler, stop_osp_task and stop_task_internal also update the report status before events are triggered, they will set current_scanner_task and global_current_report temporarily / within the forked process.
bjoernricks
approved these changes
Mar 8, 2021
timopollmeier
added
backport-to-21.04
backport-to-main
|
@Mergifyio refresh |
|
Command
|
timopollmeier
added a commit
that referenced
this pull request
Mar 16, 2021
The conflicts were a changelog entry and a case in stop_task_internal used only for the now removed GMP scanners.
|
@Mergifyio backport gvmd-21.04 |
|
Command
|
timopollmeier
added a commit
that referenced
this pull request
Mar 16, 2021
The conflicts were a changelog entry and a case in stop_task_internal used only for the now removed GMP scanners.
nichtsfrei
added a commit
that referenced
this pull request
Mar 17, 2021
Update report run status more consistently (bp #1434)
nichtsfrei
added a commit
that referenced
this pull request
Mar 17, 2021
Update report run status more consistently (bp #1434)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
To ensure the task status changes in fork_osp_scan_handler,
stop_osp_task and stop_task_internal also update the report status
before events are triggered, they will set current_scanner_task and
global_current_report temporarily / within the forked process.
Why:
Because the report status was only updated after the status change event,
the "Severity at least" condition on finished reports was evaluated for the
previous report, not the latest one.
How did you test it:
I tested this by checking current_scanner_task and global_current_report
set_task_run_status_internal and running a task with an alert that is triggered
when a task changes to "Done" and that has a minimum severity.
In the test runs I switched the target on and off to get different severity scores.
Checklist: