Fix size calculation in --optimize vacuum
#1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The database size was still trying to stat a filesystem path as used by SQLite as the database name. This is changed to use the SQL function pg_database_size instead and also the case where the size increases is now handled.
timopollmeier
added
backport-to-21.04
backport-to-main
In the "vacuum" case, old_size and new_size no longer need to be initialized with 0.
nichtsfrei
approved these changes
Mar 17, 2021
This was referenced Mar 17, 2021
timopollmeier
added a commit
that referenced
this pull request
Mar 17, 2021
Fix size calculation in `--optimize vacuum` (bp #1447)
timopollmeier
added a commit
that referenced
this pull request
Mar 17, 2021
Fix size calculation in `--optimize vacuum` (bp #1447)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The database size was still trying to stat a filesystem path as used
by SQLite as the database name.
This is changed to use the SQL function pg_database_size instead and
also the case where the size increases is now handled.
Why:
This fixes the warnings about the failed stats reported in #1432.
How did you test it:
By running
gvmd --optimize vacuumafter importing and deleting several reports.Checklist: