Fix "not regexp ..." filters #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the filters where a "regexp" clause was negated generated invalid SQL, which has been fixed.
timopollmeier
added
backport-to-21.04
backport-to-main
bjoernricks
approved these changes
Apr 13, 2021
This was referenced Apr 13, 2021
timopollmeier
added a commit
that referenced
this pull request
Apr 14, 2021
Fix "not regexp ..." filters (bp #1482)
timopollmeier
added a commit
that referenced
this pull request
Apr 14, 2021
Fix "not regexp ..." filters (bp #1482)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This fixes the way SQL for negated regexp clauses is generated.
Why:
Using the filters where a "regexp" clause was negated generated invalid
SQL.
How did you test it:
By using a filter that contained a negated "regexp", e.g.
not regexp CVE-(2000-1050|2001-0404)and one that contained a negated columnless "like" / "~" filter, e.g.
not ~"CVE-2000"Checklist: