Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column modification_time to the table reports in manage_pg.c #1519

Merged

Conversation

jhelmold
Copy link
Member

@jhelmold jhelmold commented May 12, 2021

What:
Added the new new column "modification_time" to the CREATE TABLE Statement for the table reports in manage_pg.c.

Why:
Make report timestamps more consistent.

How did you test it:

Checklist:

@jhelmold jhelmold force-pushed the new_modification_time_for_reports branch from 0c7b12d to e95d1d5 Compare May 12, 2021 13:41
@jhelmold jhelmold force-pushed the new_modification_time_for_reports branch from e95d1d5 to 4136cbc Compare May 12, 2021 13:54
@jhelmold jhelmold changed the title Add column modification_time to the CREATE TABLE Statement for Add column modification_time to the table reports in manage_pg.c May 12, 2021
@timopollmeier timopollmeier marked this pull request as ready for review May 12, 2021 14:11
@timopollmeier timopollmeier requested a review from a team as a code owner May 12, 2021 14:11
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new column should have a data type, in this case "integer".

src/manage_pg.c Outdated Show resolved Hide resolved
Co-authored-by: Timo Pollmeier <timo.pollmeier@greenbone.net>
@jhelmold jhelmold requested a review from timopollmeier May 12, 2021 14:46
@timopollmeier timopollmeier merged commit b936dfc into greenbone:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants