-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed OVAL definitions from gvmd #1525
Merged
timopollmeier
merged 7 commits into
greenbone:master
from
jhelmold:remove_oval_definitions_from_gvmd
May 20, 2021
Merged
Removed OVAL definitions from gvmd #1525
timopollmeier
merged 7 commits into
greenbone:master
from
jhelmold:remove_oval_definitions_from_gvmd
May 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed all occurences of OVAL-Definitios specific code from the gvmd sources, especially from gmp.c, manage.c, manage.h, manage_acl.c, manage_pg.c, manage_sql.c, manage_sql.h, manage_sql_secinfo.c, manage_sql_secinfo.h and manage_utils.c. Set GVMD_SCAP_DATABASE_VERSION in CMakeLists.txt from 18 to 19.
timopollmeier
requested changes
May 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you overlooked the CVEs case for the vulns
view and there's another small change I'm not sure if it's intentional.
Also, you should also remove the file tools/ovaldef_getbyname.xsl as it's no longer used.
manage_pg.c that handles CVEs.
the task "Remove OVAL definitions from gvmd" Added the missing "else" keyword in function "handle_get_info ()" in gmp.c. Deleted the file tools/ovaldef_getbyname.xsl because it is no longer used.
jhelmold
force-pushed
the
remove_oval_definitions_from_gvmd
branch
from
May 19, 2021 07:19
f99e641
to
2a5aecd
Compare
from CMakeLists.txt. Removed entry "tools/ovaldef_getbyname.xsl" from the respective install statement in the install section of CMakeLists.txt.
timopollmeier
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Removed all occurences of OVAL-Definitios specific code
from the gvmd sources, especially from gmp.c, manage.c,
manage.h, manage_acl.c, manage_pg.c, manage_sql.c,
manage_sql.h, manage_sql_secinfo.c, manage_sql_secinfo.h
and manage_utils.c. Set GVMD_SCAP_DATABASE_VERSION in
CMakeLists.txt from 18 to 19.
Why:
OVAL definitions are not supported any longer.
How did you test it:
Tested scans, reports and checked database.
Checklist: