Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed OVAL definitions from gvmd #1525

Merged

Conversation

jhelmold
Copy link
Member

What:
Removed all occurences of OVAL-Definitios specific code
from the gvmd sources, especially from gmp.c, manage.c,
manage.h, manage_acl.c, manage_pg.c, manage_sql.c,
manage_sql.h, manage_sql_secinfo.c, manage_sql_secinfo.h
and manage_utils.c. Set GVMD_SCAP_DATABASE_VERSION in
CMakeLists.txt from 18 to 19.

Why:
OVAL definitions are not supported any longer.

How did you test it:
Tested scans, reports and checked database.

Checklist:

jhelmold added 2 commits May 17, 2021 15:16
Removed all occurences of OVAL-Definitios specific code
from the gvmd sources, especially from gmp.c, manage.c,
manage.h, manage_acl.c, manage_pg.c, manage_sql.c,
manage_sql.h, manage_sql_secinfo.c, manage_sql_secinfo.h
and manage_utils.c. Set GVMD_SCAP_DATABASE_VERSION in
CMakeLists.txt from 18 to 19.
@jhelmold jhelmold marked this pull request as ready for review May 18, 2021 06:31
@jhelmold jhelmold requested a review from a team as a code owner May 18, 2021 06:31
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you overlooked the CVEs case for the vulns view and there's another small change I'm not sure if it's intentional.
Also, you should also remove the file tools/ovaldef_getbyname.xsl as it's no longer used.

src/manage_pg.c Show resolved Hide resolved
src/gmp.c Outdated Show resolved Hide resolved
@jhelmold jhelmold requested a review from timopollmeier May 19, 2021 06:37
the task "Remove OVAL definitions from gvmd"

Added the missing "else" keyword in function "handle_get_info ()"
in gmp.c. Deleted the file tools/ovaldef_getbyname.xsl because it
is no longer used.
@jhelmold jhelmold force-pushed the remove_oval_definitions_from_gvmd branch from f99e641 to 2a5aecd Compare May 19, 2021 07:19
jhelmold and others added 3 commits May 19, 2021 10:46
from CMakeLists.txt.

Removed entry "tools/ovaldef_getbyname.xsl" from the respective
install statement in the install section of CMakeLists.txt.
@timopollmeier timopollmeier merged commit 04ac931 into greenbone:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants