Fix sending prefs for whole, growing VT families #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a VT family is growing and all VTs are selected, vt_single elements are used instead of a vt_group one again so preferences can be set for the VTs.
bjoernricks
approved these changes
Jul 6, 2021
sarahd93
added a commit
that referenced
this pull request
Jul 6, 2021
Fix sending prefs for whole, growing VT families (backport #1603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
If a VT family is growing and all VTs are selected, vt_single elements
are used instead of a vt_group one again so preferences can be set for
the VTs.
Why:
The preferences were not sent for VTs where the whole family was selected.
How did you test it:
By running a scan with a config where the preference "Disable brute force checks" of NVT "Options for Brute Force NVTs" (1.3.6.1.4.1.25623.1.0.103697) in the Settings family was set to "yes" and monitoring Redis whether the preference appears with
sudo redis-cli -s /run/redis-openvas/redis.sock monitor > /tmp/redis.logChecklist: