Use less report cache SQL when adding results #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple results are added when handling an OSP get_scan response or a host in a CVE scan, only one SQL statement each is run to update the report and owner of the results and to update the end times of the report_counts cache of the report. This addresses AP-1495.
bjoernricks
approved these changes
Jul 7, 2021
bjoernricks
added
the
backport-to-oldstable
timopollmeier
added a commit
that referenced
this pull request
Jul 7, 2021
The parse_osp_report function did not use has_results before and there is no modification_time to update in 21.04 and before.
timopollmeier
added a commit
that referenced
this pull request
Jul 7, 2021
The parse_osp_report function did not use has_results before and there is no modification_time to update in 21.04 and before. The CHANGELOG entry is also moved to 20.8.3 here.
2 tasks
bjoernricks
added a commit
that referenced
this pull request
Jul 8, 2021
Use less report cache SQL when adding results (backport #1618)
bjoernricks
added a commit
that referenced
this pull request
Jul 8, 2021
Use less report cache SQL when adding results (backport #1618)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
When multiple results are added when handling an OSP get_scan response
or a host in a CVE scan, only one SQL statement each is run to update
the report and owner of the results and to update the end times of the
report_counts cache of the report.
Why:
This addresses AP-1495: Updating the report_counts for each result
can cause performance issues if the scanner returns a large amount of
results.
How did you test it:
By running a normal scan and a CVE one.
Checklist: