Use libtheia for get_license GMP command #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timopollmeier
force-pushed
the
use-libtheia
branch
2 times, most recently
from
343866c to
a42bc70
Compare
jhelmold
previously approved these changes
Oct 13, 2021
timopollmeier
force-pushed
the
use-libtheia
branch
from
371f299 to
0894620
Compare
This replaces the dummy license with actual data fetched using the optional licensing client library libtheia. If the library is not available, license commands will always return "Service not available" responses.
The new option sets the address of the publish-subscribe broker used for communication with the licensing service.
The licensing now has to be enabled explicitly with the new option in which case the theia library will be required.
timopollmeier
force-pushed
the
use-libtheia
branch
from
0894620 to
36205cf
Compare
The new setting (bb051ce6-de58-4bcf-bacd-7743797b22fa) is set automatically if gvmd is built with licensing functions and cannot be modified via GMP or the --modify-setting command line option. If gvmd is built without licensing, the setting is removed.
timopollmeier
force-pushed
the
use-libtheia
branch
from
30a6ce2 to
d560898
Compare
If gvmd is build without libtheia, the commands `get_license` and `modify_license` will be disabled as if they were disabled with in the `--disable-cmds` option.
timopollmeier
force-pushed
the
use-libtheia
branch
from
d560898 to
3afd1a6
Compare
jhelmold
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This replaces the dummy license with actual data fetched using the
optional licensing client library libtheia.
If the library is not available, license commands will always return
"Service not available" responses.
Why:
This is part of integrating the licensing service into gvmd.
How did you test it:
By building gvmd with and without libtheia and requesting license info via gvm-cli in the following situations:
Checklist: