Change failed call to xsltproc to a warning #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing things must be logged as a warning because this might indicate serious issues.
y0urself
approved these changes
Dec 6, 2021
timopollmeier
approved these changes
Dec 6, 2021
y0urself
added a commit
that referenced
this pull request
Dec 6, 2021
Change failed call to xsltproc to a warning (backport #1756)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Failing things must be logged as a warning because this might indicate
serious issues.
Why:
Without logging this error as warning a user might not find the issue.
How did you test it:
Checklist: