Fix: task status overwrite when a task is stopped and quickly restarted (not resumed) #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because the scan is in the right status. This will avoid to rewrite in the status for this report/task in the db.
It must retry only if there is a connection problem. This reduce the waiting time when the scan task was already deleted from ospd, and will not retry.
jhelmold
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix: task status overwrite when a task is stopped and quickly restarted (not resumed)
Jira: SC-505
Why:
The still stopping task will overwrite the recentrly started task (the same task, different reports). This produces that the task is set in the DB as stopped, while it was actually started in ospd-openvas. The task will run in the background.
How did you test it:
start a task, stop it, and start it again as quick as possible. Without the patch the task is stopped in gvmd but runs in background. With the patch, the it works as expected.
Checklist: