Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use g_memdup2 instead of the deprecated g_memdup #1825

Merged
merged 1 commit into from
May 16, 2022

Conversation

timopollmeier
Copy link
Member

What:

Why:
To avoid warnings about the use of a deprecated function.

How did you test it:

Checklist:

  • Tests
  • PR merge commit message adjusted

@timopollmeier timopollmeier requested a review from a team as a code owner May 12, 2022 08:49
@y0urself
Copy link
Member

g_memdup2 is available since glib 2.68, but the Checks run with 2.66 ...
https://github.com/greenbone/gvmd/runs/6402681362?check_suite_focus=true#step:4:36

@y0urself
Copy link
Member

I wonder how this works in scanner etc.
https://packages.debian.org/source/bullseye/glib2.0 is only available with 2.66
but according to https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1927 this should be backported to 2.66?

@timopollmeier
Copy link
Member Author

g_memdup2 is available since glib 2.68, but the Checks run with 2.66 ... https://github.com/greenbone/gvmd/runs/6402681362?check_suite_focus=true#step:4:36

I've added a version check so it should work with older versions.

@timopollmeier timopollmeier enabled auto-merge May 12, 2022 09:02
@timopollmeier timopollmeier merged commit 4ad2491 into greenbone:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants