Fixed the number of results in triggered alerts. #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the number of results for automatically triggered alerts and manually triggered alerts are the same.
Now the selected report is used for the manually triggered alert. Previously only the latest report (not the selected one) was used for the alert.
timopollmeier
requested changes
Jan 9, 2023
|
@jhelmold you should enable Auto-merge (squash) when you are done with your PR and use a proper conventional commit message for this. Thank you. :) |
timopollmeier
approved these changes
Jan 13, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Fixed the number of results in triggered alerts. Now the number of results for automatically triggered alerts and manually triggered alerts are the same. * Fixed small memory bug. * Use selected report for manually triggered alert. Now the selected report is used for the manually triggered alert. Previously only the latest report (not the selected one) was used for the alert. * Refactoring of the first solution. * Added the header comment for the function "init_alert_get_data". (cherry picked from commit ea67ea3)
y0urself
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Fixed the number of results in triggered alerts. Now the number of results for automatically triggered alerts and manually triggered alerts are the same. * Fixed small memory bug. * Use selected report for manually triggered alert. Now the selected report is used for the manually triggered alert. Previously only the latest report (not the selected one) was used for the alert. * Refactoring of the first solution. * Added the header comment for the function "init_alert_get_data". (cherry picked from commit ea67ea3) Co-authored-by: Johannes Helmold <83279292+jhelmold@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the number of results in triggered alerts.
What:
Now the number of results for automatically triggered alerts and manually triggered alerts are the same.
In addition now the selected report (not always the latest report) is used when manually triggering an alert.
Why:
This is a bug-fix. Addresses T4-420 and T4-411.
How did you test it:
Checklist: