Fix: Make matching for prefs migration stricter #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrating NVT and config preferences use regexp matching to ensure only ones where the substrings can be extracted are selected for the update. This addresses the migration failing because of preferences containing a colon but not having the expected pattern.
timopollmeier
added
backport-to-stable
patch release
and removed
make patch release
labels
Conventional Commits Report
🚀 Conventional commits found. |
bjoernricks
approved these changes
Jul 6, 2023
timopollmeier
added a commit
that referenced
this pull request
Jul 7, 2023
Fix: Make matching for prefs migration stricter (backport #2036)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When migrating NVT and config preferences use regexp matching to ensure only ones where the substrings can be extracted are selected for the update.
Why
This addresses the migration failing because of preferences containing a colon but not having the expected pattern.
References
GEA-244