Drop otp nvt update #575
Drop otp nvt update #575
Conversation
janowagner
added
the
work in progress
janowagner
force-pushed
the
drop_otp_nvt_update
branch
2 times, most recently
from
ff37c87 to
ef5e937
Compare
janowagner
removed
the
work in progress
There was a problem hiding this comment.
This is great, but there is still some OTP NVT update code in there.
gvmd.c should no longer be calling update_nvt_cache. As a result init_gmpd,
init_gmp, init_manage, etc no longer need the nvt_cache_mode argument.
Also --osp-vt-update should change, because it is the only option. Could be
replaced with --vt-update-socket. And we need a default in case it is not given.
This also removes acknowledge_feed_version_info() which wasn't used anywhere.
This function is not needed anymore. Subsequently also functions update_old_config_preferences(), insert_nvts_list() and insert_nvt_from_nvti(). The function make_nvt_from_nvti() is actually not needed also. But it might be used for chunked insertion of nvts and therefore it is kept and a dumy call added to make the compiler accept the presence.
Subsequently, also used functions and a static global vairable are removed as they are unused now.
And subsequently unused global variable.
This is to be consistent with other protos.
Currently it is not really used, so remove it. If we really need it later, we can pull it from the repository.
This function handled OTP-based NVT update. Removed call of this function and also the function itself.
It is only called with 0 anyway.
It is called with "0" always anyway.
It is called with "0" always anyway.
It is called with "0" always anyway.
It is always "0", so remove the parameter and the conditional for non-"0" as it can never happen anymore.
janowagner
force-pushed
the
drop_otp_nvt_update
branch
from
434e01f to
de2c113
Compare
Done. |
I suggest to keep as is and consolidate once the entire OTP is replaced by OSP. |
Would like to see some sort of warning so this doesn't catch people out, but I want |
This pull request removed the handling of NVT updates via OTP.
Any code parts that are subsequently not needed anymore are also removed.