Don't handle qod_type via tags. #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a unintended redundancy. The qod_type is handled explicitley in the table "nvts" and also in the "nvt" GMP object. But it also still occurs in the tags element which does not make sense. Analog to the timestamps it should have been removed from there. This patch uses the new API for the nvti object to add the QoD Type directly when loading a OSP VT object rather than adding it to the "tags" element. Consequently, it will get the qod_type via the new API rather than parse it from the tags section. This change has two advantages: * In column "tags" of table "nvts" the string element "|qod_type=some-type" is not added anymore. This saves space and parsing time. * The qod_type is not parsed from the tags element anymore. This saves parsing time. The gains might not be significant though. The user API is changed at the level of a bug fix: The "qod_type=" part of the tags should have never been there and never be used. It was undocumented anyway.
|
The changes depend on greenbone/gvm-libs#250 The build tests will fail until that patch is merged. |
mattmundell
approved these changes
Jul 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a unintended redundancy. The qod_type
is handled explicitley in the table "nvts" and also in the "nvt" GMP
object. But it also still occurs in the tags element which does
not make sense. Analog to the timestamps it should have been removed
from there.
This patch uses the new API for the nvti object to add the QoD Type
directly when loading a OSP VT object rather than adding it to
the "tags" element.
Consequently, it will get the qod_type via the new API rather than
parse it from the tags section.
This change has two advantages:
In column "tags" of table "nvts" the string element
"|qod_type=some-type" is not added anymore.
This saves space and parsing time.
The qod_type is not parsed from the tags element anymore.
This saves parsing time.
The gains might not be significant though.
The user API is changed at the level of a bug fix:
The "qod_type=" part of the tags should have never been there
and never be used. It was undocumented anyway.
Checklist: