Add sensor relays and OSP sensors #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a suitable relay mapper executable is given it will replace the connection data of the scanner with that of a relay.
The new scanner type can be used to connect to ospd-openvas scanners, optionally via a relay like GMP scanner.
Only scanners of type SCANNER_TYPE_GMP require a credential now. Also, the error messages for missing elements are now more specific.
The credential can now be removed for types other than SCANNER_TYPE_GMP and will be always be checked in case a scanner of a different type is changed to SCANNER_TYPE_GMP.
This adds the option to the man page and logs all non-warning output for it at the debug level.
mattmundell
requested changes
Sep 25, 2019
The new_ca_cert parameter is used for output, not input. Co-Authored-By: Matt Mundell <32057441+mattmundell@users.noreply.github.com>
The cases for using a UNIX socket and a TCP port were reversed.
OSP scanners can now also provide a list of available system/performance reports with the GET_PERFORMANCE command. This does not yet include getting the actual graphs.
The GMP command get_system_reports can now get its reports from OSP scanners, not just the a list of available ones.
|
In addition to the requested changes I've also added the use of OSP sensors for the |
mattmundell
requested changes
Sep 26, 2019
The scanner info string like the host and certificate have to be freed.
The get_slave_system_report_types and gmp_slave_system_report functions will return -1 if slave is 0 because this should be checked before they are called. The doc of these functions now also no longer contains the unused return values 2 and 3.
The comment is now put after the variable declaration.
mattmundell
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way to replace connections to remote scanners with connections to relays and a new OSP sensor scanner type.
Checklist: