Accelerate VT feed update #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janowagner
requested review from
mattmundell and
timopollmeier
as code owners
janowagner
added
the
work in progress
And use them to issue the events that actually are called via check_for_updated_nvts() and check_for_new_nvts(). This way the SQL statements from those two functions are not executed anymore. This accelerates a update by about 7 minutes down to a few seconds.
check_for_new_nvts() and check_for_updated_nvts() are moved now.
janowagner
force-pushed
the
accelerate_feed_update
branch
from
75c384a to
dc77e67
Compare
janowagner
removed
the
work in progress
mattmundell
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a SQL query based on a copy of the nvts table, directly count
the new and modified VTs as they are loaded via OSP.
Use these values to determine about issuing events.
This reduces the update times from about 7 minutes to a few seconds.
Checklist: