-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get scanner preferences from OSP-OpenVAS scanner #766
Merged
mattmundell
merged 5 commits into
greenbone:master
from
timopollmeier:scanner-prefs-from-osp
Oct 1, 2019
Merged
Get scanner preferences from OSP-OpenVAS scanner #766
mattmundell
merged 5 commits into
greenbone:master
from
timopollmeier:scanner-prefs-from-osp
Oct 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preferences of the OpenVAS scanner are expected to be in the nvt_preferences table, so they have to be added there.
mattmundell
requested changes
Oct 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't test right now. Idea looks right.
This reduces the scope of the variable to the block it is used in.
jjnicola
reviewed
Oct 1, 2019
The id has to be used instead of the name here.
timopollmeier
added
work in progress
This pull request should not be merged yet, more commits are expected
and removed
work in progress
This pull request should not be merged yet, more commits are expected
labels
Oct 1, 2019
I tested and I was able to see and modify the scanner preferences. |
mattmundell
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preferences of the OpenVAS scanner are expected to be in the
nvt_preferences table, so they have to be added there.
Checklist: