Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get scanner preferences from OSP-OpenVAS scanner #766

Merged
merged 5 commits into from
Oct 1, 2019

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Oct 1, 2019

The preferences of the OpenVAS scanner are expected to be in the
nvt_preferences table, so they have to be added there.

Checklist:

The preferences of the OpenVAS scanner are expected to be in the
nvt_preferences table, so they have to be added there.
@timopollmeier timopollmeier marked this pull request as ready for review October 1, 2019 14:11
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test right now. Idea looks right.

src/manage_sql_nvts.c Outdated Show resolved Hide resolved
src/manage_sql_nvts.c Show resolved Hide resolved
src/manage_sql_nvts.c Outdated Show resolved Hide resolved
src/manage_sql_nvts.c Outdated Show resolved Hide resolved
The id has to be used instead of the name here.
@timopollmeier timopollmeier added work in progress This pull request should not be merged yet, more commits are expected and removed work in progress This pull request should not be merged yet, more commits are expected labels Oct 1, 2019
@timopollmeier timopollmeier requested a review from jjnicola October 1, 2019 15:43
@jjnicola jjnicola requested review from jjnicola and removed request for jjnicola October 1, 2019 15:48
@jjnicola
Copy link
Member

jjnicola commented Oct 1, 2019

I tested and I was able to see and modify the scanner preferences.

@mattmundell mattmundell merged commit fbe3390 into greenbone:master Oct 1, 2019
@timopollmeier timopollmeier deleted the scanner-prefs-from-osp branch June 9, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants