Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra TLS certificate info, rename last_collected to last_seen (master) #775

Merged

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Oct 7, 2019

The sources of TLS certificates now contain the asset UUID of the host.
If the origin is a report they will also contain the report timestamp
and the task.
Also, the last_collected element and filter column are renamed to last_seen.

Checklist:

The sources of TLS certificates now contain the asset UUID of the host.
If the origin is a report they will also contain the report timestamp
and the task.
This adds documentation for the tls_certificate_origin_extra_xml and
tls_certificate_host_asset_id functions and fixes a typo of the
tls_certificate_origin_extra_xml parameter name "origin_data".
This changes the name of the XML element and filter columns.
@timopollmeier timopollmeier marked this pull request as ready for review October 7, 2019 09:08
src/manage_sql_tls_certificates.c Outdated Show resolved Hide resolved
@mattmundell mattmundell self-requested a review October 7, 2019 10:20
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, meant to request changes.

As it mostly generates GMP XML, it has been moved to the GMP handling
files gmp_tls_certificates.c and gmp_tls_certificates.h.
@mattmundell mattmundell merged commit b0ccdbd into greenbone:master Oct 7, 2019
@@ -21,7 +21,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
## [9.0.0] (unreleased)

### Added
- Added TLS certificates as a new resource type [#585](https://github.com/greenbone/gvmd/pull/585) [#663](https://github.com/greenbone/gvmd/pull/663) [#673](https://github.com/greenbone/gvmd/pull/673) [#674](https://github.com/greenbone/gvmd/pull/674) [#689](https://github.com/greenbone/gvmd/pull/689) [#695](https://github.com/greenbone/gvmd/pull/695) [#703](https://github.com/greenbone/gvmd/pull/703) [#728](https://github.com/greenbone/gvmd/pull/728) [#732](https://github.com/greenbone/gvmd/pull/732) [#750](https://github.com/greenbone/gvmd/pull/750) [#752](https://github.com/greenbone/gvmd/pull/752)
- Added TLS certificates as a new resource type [#585](https://github.com/greenbone/gvmd/pull/585) [#663](https://github.com/greenbone/gvmd/pull/663) [#673](https://github.com/greenbone/gvmd/pull/673) [#674](https://github.com/greenbone/gvmd/pull/674) [#689](https://github.com/greenbone/gvmd/pull/689) [#695](https://github.com/greenbone/gvmd/pull/695) [#703](https://github.com/greenbone/gvmd/pull/703) [#728](https://github.com/greenbone/gvmd/pull/728) [#732](https://github.com/greenbone/gvmd/pull/732) [#750](https://github.com/greenbone/gvmd/pull/750) [#752](https://github.com/greenbone/gvmd/pull/752) [#775](https://github.com/greenbone/gvmd/pull/774)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the link on 775 is 774 on this.

@timopollmeier timopollmeier deleted the extra-tls_certificate-info-master branch June 9, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants