Try to get NVT preferences by id in create_config (9.0) #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing a config try to get the preferences by their id from the nvt_preferences table in case their name has changed since the config was exported.
The log message about getting the preference by name is only generated when no id is given because it would be redundant for a id change.
mattmundell
requested changes
Oct 22, 2019
There was a problem hiding this comment.
I've reviewed the code but I'm not sure we should be allowing preferences to be specified by name. I will look more at the plan for preferences to try understand.
Also I wonder about creating multiple preference_t's during the import. It seems a bit convoluted. Wouldn't it be better to create the preference_t once with the right id/name in create_config_run?
These functions are not just used by the GMP layer, so they are moved to a new source file, gmp_configs.c.
The preferences are now fetched when processing the XML to avoid building prefrerence_t structs twice.
The name is now only used to log changes if it is different from the one in nvt_preferences.
If a type is given, a warning is logged if it is different from the one in nvt_preferences.
|
I've updated the PR to remove the selection by preference name, simplify the selection from the |
mattmundell
requested changes
Oct 23, 2019
The NULL value first assigned to alts was unused.
mattmundell
approved these changes
Oct 24, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a config try to get the preferences by their id from the
nvt_preferences table in case their name has changed since the config
was exported.
Checklist: