Unified vt solution #849
Merged
Unified vt solution #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janowagner
force-pushed
the
unified_vt_solution
branch
3 times, most recently
from
a42c09e to
e183d95
Compare
janowagner
requested review from
mattmundell and
timopollmeier
as code owners
janowagner
added
the
work in progress
|
Just to be sure, you added "work in progress" so this is not ready for review anymore? |
Indeed. I thought it is and changed the status, but I found no way back to the previous status after |
janowagner
force-pushed
the
unified_vt_solution
branch
from
e183d95 to
5e84126
Compare
janowagner
removed
the
work in progress
janowagner
force-pushed
the
unified_vt_solution
branch
2 times, most recently
from
13c0a20 to
ad5ce6f
Compare
|
@mattmundell could you review this PR? |
mattmundell
requested changes
Nov 28, 2019
Use the solution text and the solution type. This keeps the same data the tag string for the time being.
This adds the solution method to the solution element in the results nvt object.
In case only a solution type and/or method is present, still create the solution element.
This adds the solution element. The solution and solution_type are still in the tag and need to be removed later.
Also considers the optional solution method and print it on a extra line.
Also considers the optional solution method and print it on a extra line.
Also considers the optional solution method and print it on a extra line.
Also considers the optional solution method and print it on a extra line.
The optional solution method is not considered because it was change the column structure and thus change the CSV API.
This boiled down to just the change note since the nvt element is not detailed anywhere in the GMP documentation.
The column is mandatory for correct function. So we need to enfore the migration.
janowagner
force-pushed
the
unified_vt_solution
branch
from
aed9ee4 to
07a51d1
Compare
mattmundell
requested changes
Nov 30, 2019
This section is meant to document changes, no additions. So, reverting it.
mattmundell
approved these changes
Nov 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parsing of solution method from OSP and store into database.
Extend GMP API for nvt object to carry a explicit solution element.
The same solution element as in the tags is not yet removed by this
pull request and will be done in a separate pull request after all
other modules adapted to the new API (new location of solution
information).
All internal consumers of the solution information (report formats)
are already adapted to the new solution element. The CSV report
format does not use the newly introduced solution method because
it would require a change about the columns.
Requires
greenbone/gvm-libs#283
Checklist: