Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Postgres 9.6 as a minimum (9.0) #872

Merged
merged 8 commits into from
Nov 20, 2019

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Nov 20, 2019

This makes Postgres 9.6 the minimum required version, to simplify
the performance oriented code that uses ON CONFLICT.

Checklist:

@mattmundell mattmundell changed the title Pg 9.6 9.0 Require Postgres 9.6 as a minimum Nov 20, 2019
@mattmundell mattmundell changed the title Require Postgres 9.6 as a minimum Require Postgres 9.6 as a minimum (9.0) Nov 20, 2019
@mattmundell mattmundell marked this pull request as ready for review November 20, 2019 08:23
bjoernricks
bjoernricks previously approved these changes Nov 20, 2019
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could check the postgres version via cmake too. Not sure if that is possible at the moment.

@mattmundell
Copy link
Contributor Author

It would be nice if we could check the postgres version via cmake too. Not sure if that is possible at the moment.

I hacked something in 3fef338. Doesn't seem to be a clean way.

@mattmundell mattmundell merged commit 5130258 into greenbone:gvmd-9.0 Nov 20, 2019
@mattmundell mattmundell deleted the pg-9.6-9.0 branch November 20, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants