Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove agents #922

Merged
merged 15 commits into from
Jan 7, 2020
Merged

Remove agents #922

merged 15 commits into from
Jan 7, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Dec 31, 2019 •
edited
Loading

Checklist:

@mattmundell mattmundell marked this pull request as ready for review December 31, 2019 14:20
@mattmundell
Copy link
Contributor Author

Not sure what happened with the GMP doc diff. Let me know if it's too hard to follow and I'll break it up.

@mattmundell mattmundell requested a review from a team January 2, 2020 11:23
@mattmundell mattmundell mentioned this pull request Jan 3, 2020
Merged
2 tasks
timopollmeier
timopollmeier requested changes Jan 6, 2020
View reviewed changes
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides one issue with the migrator this looks fine to me.

src/manage_migrators.c Outdated Show resolved Hide resolved
@mattmundell
Remove DELETE from migrator
904e6ed 
This would cause constraint failures.  The tag resources will be deleted
anyway.
@timopollmeier timopollmeier merged commit 917c859 into greenbone:master Jan 7, 2020
@mattmundell mattmundell deleted the remove-agents branch January 7, 2020 12:02
@y0urself y0urself mentioned this pull request Jul 6, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timopollmeier timopollmeier timopollmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @timopollmeier