-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit error for wrong arg order in nasl_functions. #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tehforsch
force-pushed
the
fix-1163
branch
4 times, most recently
from
September 18, 2024 09:03
4c71e31
to
1559e16
Compare
Previously, the context and the register increased the argument count and would increase the index of any subsequent positional arguments. Now, they are not counted, as it should be. This also adds an error message if the Context or the Register are not in front of the positional arguments and imposes strict requirements for the ordering of all argument types, namely 1. Context/Register 2. Positionals 3. Maybe positionals (i.e. arguments that can also be named) 4. Named arguments 5. Argument lists i.e. `Named` and `Positionals`.
Kraemii
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a small change, for printing the error. The rest looks good to me
Co-authored-by: Christoph Krämer <c.kraemer.rulle@web.de>
Kraemii
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: SC-1163.
I also fixed places where the arguments were not properly ordered. While doing so, I noticed that a few
nasl_functions
mention nonexistent args in the attrs of the macro. I turned this into a hard error, since it can lead to problems such as inscanner_add_port
.