Send duplicated hosts as dead hosts to ospd, to adjust scan progress calculation #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why calling the function twice and not save it in a variable? |
The function just access a variable. It doesn't do any extra process. If you think it can improved the code readability, I can change it. |
|
Just a hint. It's up to you. ;-) |
…calculation. Duplicated hosts are removed from the list and ospd-openvas needs to know that less hosts will be scanned, for the scan progress calculation. Sent the amount of duplicated hosts as dead hosts to not be taken in account.
ArnoStiefvater
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicated hosts are removed from the list and ospd-openvas
needs to know that less hosts will be scanned, for the scan progress
calculation. Sent the amount of duplicated hosts as dead hosts to not
be taken in account.
Depends on PR greenbone/gvm-libs#387