Get results from main kb. #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
force-pushed
the
results-main-kb-only
branch
from
57e909f to
11001c0
Compare
The host progress is stored by openvas in the scan main kb now. The host status are all under the same key and to differentiate them, are prefixed with the host ip. All hosts status are fetched at once.
There is no need to get current_host from redis. This is so because the results are stored all under the same key in the main kb. This reduce significantly the redis queries and kb select/change.
The log messages are under the internal/results in the main kb and are fetch as the other results.
This reduces the access to the scan table which speeds up the scan.
Removes unnecessary methods which were used to check the host process. Now the results are in the main kb and host are controled/check/finished by openvas
jjnicola
force-pushed
the
results-main-kb-only
branch
from
8b6d305 to
7d06eb9
Compare
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 81.94% 84.41% +2.46%
==========================================
Files 9 9
Lines 1501 1469 -32
==========================================
+ Hits 1230 1240 +10
+ Misses 271 229 -42
Continue to review full report at Codecov.
|
|
Depends on PR greenbone/openvas-scanner#550 and PR greenbone/gvm-libs#376 |
bjoernricks
approved these changes
Jul 15, 2020
ArnoStiefvater
pushed a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
Allow a client to request start_scan during feed update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenVAS stores now the results in the main task DB and all results are stored in the same internal/results kb in the main kb.
This allows to get all results stored in redis for all target's hosts at once. Also, avoid to loop looking for results in each single host kb.
Because it does not check the host kbs, ospd-openvas does not release them anymore and this is done by OpenVAS, unless in edge cases in which a scan is stopped or OpenVAS dies unexpectedly, ospd-openvas does the redis cleanup.