Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Use better defaults for file paths and permissions (backport #429) #431

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 1, 2021

This is an automatic backport of pull request #429 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@mergify mergify bot requested a review from a team as a code owner July 1, 2021 10:51
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #431 (345669c) into ospd-21.04 (8ad2dcb) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 345669c differs from pull request most recent head cd6de0f. Consider uploading reports for the commit cd6de0f to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           ospd-21.04     #431   +/-   ##
===========================================
  Coverage       74.67%   74.67%           
===========================================
  Files              23       23           
  Lines            2638     2638           
===========================================
  Hits             1970     1970           
  Misses            668      668           
Impacted Files Coverage Δ
ospd/parser.py 91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20c2f2...cd6de0f. Read the comment docs.

bjoernricks
bjoernricks previously approved these changes Aug 5, 2021
@bjoernricks bjoernricks enabled auto-merge August 5, 2021 09:03
@bjoernricks
Copy link
Contributor

@Mergifyio rebase

* /var/run is just a symlink to /run nowadays.
* Allow user and group to access to socket by default. This allows for
  querying data from osp in a multi-user setup more easily.
* Move pid file within /run/ospd
* There is no /usr/var directory by default. Therefore change the path
  to the certs to something that makes sense

(cherry picked from commit 64571cb)
(cherry picked from commit 352d01e)
@mergify
Copy link
Author

mergify bot commented Aug 5, 2021

Command rebase: success

Branch has been successfully rebased

@bjoernricks bjoernricks merged commit a27f719 into ospd-21.04 Aug 5, 2021
@bjoernricks bjoernricks deleted the mergify/bp/ospd-21.04/pr-429 branch August 5, 2021 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants