Treemap #128
Merged
Treemap #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To have more control and to spare the creation of a squarify debian package a simplified fork of https://github.com/laserson/squarify is created to enable creation of treemaps in svg directly without using matplotlib or alike.
Due to version switch from 3 to 2 asgi is not supported and is removed. Add doctests to treemap.py for demonstration purpose, add doc test execution to pytest due to that.
The bar chart is missing an closing g element and the svg image replacement worked just for the first svg and will then produce gibberish since the index has changed on html change. In the moment it is using recursion, which should be replaced because python does not nor will ever optimize tail recursion.
to reduce te overhead on a recurision it replace_inline_svg is using a while loop to find all svgs if no svg was found than it returns the html.
y0urself
requested changes
Dec 1, 2020
use Rect class instead of x, y, dx, dy as parameter Co-authored-by: Jaspar L. <jstach@uos.de>
instead of using 4 parameter everywhere use the data class Rect for it.
To be more consistent and easier to read svg templates are using just named form parameter instead of only when > 3 and reusing.
y0urself
requested changes
Dec 2, 2020
indicate Rect return value Co-authored-by: Jaspar L. <jstach@uos.de>
y0urself
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
To have more control and to spare the creation of a squarify debian
package a simplified fork of https://github.com/laserson/squarify
is created to enable creation of treemaps in svg directly without
using matplotlib or alike.
Why:
To have an rough overview of scanned hosts a treemap was wanted i the overview page.
How:
Create a template, e.g:
and create a html report.
Checklist: