Fix: Fix version scheme, by avoiding version jump on pre-releases #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y0urself
force-pushed
the
y0urself/correct-versioning
branch
from
83d72a3 to
a7beb54
Compare
Codecov Report
@@ Coverage Diff @@
## main #674 +/- ##
=======================================
Coverage 89.45% 89.46%
=======================================
Files 79 79
Lines 4950 4954 +4
Branches 661 663 +2
=======================================
+ Hits 4428 4432 +4
Misses 368 368
Partials 154 154
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
On hold for major changes in the Version module of pontos regarding SemVer. |
y0urself
force-pushed
the
y0urself/correct-versioning
branch
from
a7beb54 to
be915c6
Compare
y0urself
force-pushed
the
y0urself/correct-versioning
branch
from
be915c6 to
0be1f6b
Compare
bjoernricks
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixing
next_minor_version()andnext_major_version()Why
0.5.0a1it will be released to0.6.0when doing a minor release, same for major releases, e.g.1.0.0a1will get2.0.0instead of the correct1.0.0.References
None.
Checklist