GMP7: Make resource_id optional when creating tags #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the protocol specification does not mention it, the implementation does in fact allow creating tags not assigned to a specific resource, provided an empty string is passed as `resource_id`.
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
======================================
Coverage 96.4% 96.4%
======================================
Files 10 10
Lines 2479 2479
======================================
Hits 2390 2390
Misses 89 89
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
======================================
Coverage 96.4% 96.4%
======================================
Files 10 10
Lines 2479 2479
======================================
Hits 2390 2390
Misses 89 89
Continue to review full report at Codecov.
|
Group `resource_id` with the other optional parameters for consistency.
bjoernricks
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the protocol specification does not mention it, the implementation
does in fact allow creating tags not assigned to a specific resource,
provided an empty string is passed as
resource_id.Checklist: