Adapt modify_tag to implementation #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt the parameter validation in `modify_tag` to the actual implementation in `gmvd` and adjust tests and documentation accordingly. The previous implementation refused a number of combinations which are are accepted by the `gvmd` from GVM-10. Most notably, the `resource_type` is rarely required, in contrast to the `create_tag` command. Also, sending *only* the `resource_type` is acceptable for modifying the type of resource a tag is intended for.
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=========================================
- Coverage 96.4% 96.4% -0.01%
=========================================
Files 10 10
Lines 2479 2478 -1
=========================================
- Hits 2390 2389 -1
Misses 89 89
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=========================================
- Coverage 96.4% 96.4% -0.01%
=========================================
Files 10 10
Lines 2479 2478 -1
=========================================
- Hits 2390 2389 -1
Misses 89 89
Continue to review full report at Codecov.
|
bjoernricks
suggested changes
May 7, 2019
Co-Authored-By: wiegandm <wiegandm@users.noreply.github.com>
Co-Authored-By: wiegandm <wiegandm@users.noreply.github.com>
Co-Authored-By: wiegandm <wiegandm@users.noreply.github.com>
Co-Authored-By: wiegandm <wiegandm@users.noreply.github.com>
Co-Authored-By: wiegandm <wiegandm@users.noreply.github.com>
bjoernricks
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the parameter validation in
modify_tagto the actualimplementation in
gmvdand adjust tests and documentation accordingly.The previous implementation refused a number of combinations which are
are accepted by the
gvmdfrom GVM-10. Most notably, theresource_typeis rarely required, in contrast to thecreate_tagcommand. Also, sending only the
resource_typeis acceptable formodifying the type of resource a tag is intended for.
Checklist: