-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boolean "no_details" option to "get_reports()" #129
Add boolean "no_details" option to "get_reports()" #129
Conversation
GMP v7 and up support the undocumented boolean parameter "details" to suppress results. As of GMP v8 this is the preferred way of getting a list of reports related to a task, since the reports are no longer included in get_tasks().
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 96.4% 96.41% +<.01%
==========================================
Files 10 10
Lines 2478 2480 +2
==========================================
+ Hits 2389 2391 +2
Misses 89 89
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 96.4% 96.41% +<.01%
==========================================
Files 10 10
Lines 2478 2480 +2
==========================================
+ Hits 2389 2391 +2
Misses 89 89
Continue to review full report at Codecov.
|
Do I understand your PR correctly that details="1" is the default? Means if the details attribute is not included in the request gvmd assumes it is 1? |
Yes, it seems to be the default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks very good!
I am not a fan of the details parameter and therefore I've not added it by intention. But if your use case really requires it, we should merge this PR.
It makes quite a big difference in the size of the xml returned, so it would be better for us. |
😒 |
@wiegandm could you take care of this PR next week? |
@bjoernricks Ack. @Kars-de-Jong, I think the comment should be the other way around, could you please check? |
…ts meaning clearer
I really don't like the no_details argument. We need to fix the protocol for this param! |
GMP v7 and up support the undocumented boolean parameter "details", which can be set to "0" to suppress results. As of GMP v8 this is the preferred way of getting a list of reports related to a task, since the reports are no longer included in get_tasks().
This closes #128.
Checklist: