Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize gmp8 part 1 #132

Merged
merged 20 commits into from
Jun 18, 2019
Merged

Finalize gmp8 part 1 #132

merged 20 commits into from
Jun 18, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Jun 18, 2019 •
edited
Loading

  • Avoid duplicate code in tests
  • Add get_vulnerabilities, get_vulnerability
  • Add create_ticket, modify_ticket, delete_ticket, get_ticket, get_tickets and clone_ticket
  • Introduce a CredentialType enum for gmpv8
  • Expect CredentialType as argument for create_credential and modify_credential in gmpv8

Checklist:

bjoernricks added 13 commits June 13, 2019 15:56
@bjoernricks
Avoid import clashes when running tests
5ddff4e 
The tests directory is moved to the beginning of the module search path.
Therefore "import xml.something" does fail in this case. Therefore avoid
using a xml module name for the tests.
@bjoernricks
Add test for version info of Gmpv7
f56f283
@bjoernricks
Add test for protocol version of Gmpv8
c1f2ed2
@bjoernricks
Update TOC in README
9132486 
Avoid including main heading and toc into the toc. Also use '-' for
unordered list in toc.
@bjoernricks
Only list one installation method in README
0c1cc7c 
It seems the users are following the README very closely without knowing
pip semantics. Therefore mention only the best fitting installation
method.
@bjoernricks
Fix docstring for sphinx
a1bfac0 
Sphinx interprets the docstring as rst. Therefore using **kwargs expects
closing **.
@bjoernricks
Generate Gmpv8 API docs
3151994 
Add GMP v8 to the docs
@bjoernricks
GMP v8 got released with GVM 10 and gvmd 8
ee22779
@bjoernricks
Change latest to use GMP v8
e37987a 
Update python-gvm to use GMPv8 as latest GMP protocol
@bjoernricks
Add base TestCase classes for Gmpv7 and Gmpv8 tests
787a99d 
Using base TestCase classes will allow to simplify the tests.
@bjoernricks
Use new base class for GMPv7 tests
fe442bd
@bjoernricks
Use new base class for GMPv8 tests
41bed7b
@bjoernricks
Add get vulnerabilities api to Gmpv8
3e8b3c8 
Implement API to receive vulnerability information.
@codecov
Copy link

codecov bot commented Jun 18, 2019 •
edited
Loading

Codecov Report

Merging #132 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   96.41%   96.56%   +0.15%     
==========================================
  Files          10       10              
  Lines        2480     2564      +84     
==========================================
+ Hits         2391     2476      +85     
+ Misses         89       88       -1
Impacted Files Coverage Δ
gvm/protocols/gmpv7.py 99.74% <ø> (ø) ⬆️
gvm/protocols/latest.py 100% <100%> (ø) ⬆️
gvm/protocols/gmpv8.py 100% <100%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b62e4...a683477. Read the comment docs.

@bjoernricks bjoernricks requested a review from wiegandm June 18, 2019 07:36
@bjoernricks bjoernricks marked this pull request as ready for review June 18, 2019 07:37
@bjoernricks bjoernricks requested a review from a team June 18, 2019 07:37
wiegandm
wiegandm requested changes Jun 18, 2019
View reviewed changes
gvm/protocols/gmpv8.py Outdated Show resolved Hide resolved
gvm/protocols/gmpv8.py Outdated Show resolved Hide resolved
@bjoernricks bjoernricks requested a review from wiegandm June 18, 2019 08:58
wiegandm
wiegandm requested changes Jun 18, 2019
View reviewed changes
gvm/protocols/gmpv8.py Show resolved Hide resolved
gvm/protocols/gmpv8.py Show resolved Hide resolved
gvm/protocols/gmpv8.py Outdated Show resolved Hide resolved
@bjoernricks
Add tickets API
d0f8ac9 
Allow to create, clone, delete, get and modify tickets.

Closes #95
@bjoernricks
Add changelog entries for gmpv8 additions
c5c2d41
@bjoernricks
Don't use trailing commas to support python 3.5
54e68f7 
We still need support for python 3.5 therefore don't add trailing commas
to method signatures.
@bjoernricks
Introduce a CredentialType enum for gmpv8
dc6fb5c 
Replace the CREDENTIAL_TYPES list with a CredentialType enum.
@bjoernricks
Update create_credential and modify_credential for Gmpv8
79efab3 
Expect a CredentialType instance for the credential_type arguments. It's
easier to use Enums for specific types for method arguments.
@bjoernricks
Fix docstrings for clone commands in gmpv7
a90e74b 
Document the correct id argument. Was a copy&paste mistake from the
protocol docs.
@bjoernricks
Add changelog entry for CredentialType enum
a683477
@bjoernricks bjoernricks requested a review from wiegandm June 18, 2019 10:48
@bjoernricks bjoernricks merged commit 11d6abd into greenbone:master Jun 18, 2019
@bjoernricks bjoernricks mentioned this pull request Jun 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiegandm wiegandm wiegandm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @wiegandm