Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic gmp protocol selection #141

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Support dynamic gmp protocol selection #141

merged 2 commits into from
Jul 22, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Jul 18, 2019

Allow to support using the gmp protocol implementation used by the
remote manager daemon.

Checklist:

Allow to support using the gmp protocol implementation used by the
remote manager daemon.
@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #141 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   96.75%   96.81%   +0.06%     
==========================================
  Files          10       11       +1     
  Lines        3082     3111      +29     
==========================================
+ Hits         2982     3012      +30     
+ Misses        100       99       -1
Impacted Files Coverage Δ
gvm/protocols/gmp.py 100% <100%> (ø)
gvm/protocols/base.py 92.85% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7cf3e1...235348d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #141 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   96.75%   96.81%   +0.06%     
==========================================
  Files          10       11       +1     
  Lines        3082     3111      +29     
==========================================
+ Hits         2982     3012      +30     
+ Misses        100       99       -1
Impacted Files Coverage Δ
gvm/protocols/gmp.py 100% <100%> (ø)
gvm/protocols/base.py 92.85% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7cf3e1...3c70cb9. Read the comment docs.

@bjoernricks bjoernricks marked this pull request as ready for review July 18, 2019 09:25
@bjoernricks bjoernricks requested a review from swaterkamp as a code owner July 18, 2019 09:25
@bjoernricks bjoernricks requested a review from jjnicola July 18, 2019 09:25
@bjoernricks bjoernricks merged commit 4f45533 into greenbone:master Jul 22, 2019
@bjoernricks bjoernricks deleted the gmp-selection branch July 22, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants