Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate make unique #156

Merged
merged 4 commits into from
Sep 19, 2019
Merged

Deprecate make unique #156

merged 4 commits into from
Sep 19, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Sep 19, 2019 •
edited
Loading

Checklist:

@bjoernricks
Ignore make_unique in create_target
54522ff 
Override create_target in Gmpv8 to ignore make_unique.
@bjoernricks
Add test for ignoring the make_unique argument
48d1227 
Test if make_unique is ignored for Gmpv8 create_target method.
@bjoernricks
Add changelog entry for deprecated make_unique
b0cce6e
@bjoernricks bjoernricks marked this pull request as ready for review September 19, 2019 10:57
wiegandm
wiegandm previously approved these changes Sep 19, 2019
View reviewed changes
tests/protocols/gmpv8/test_create_target.py Show resolved Hide resolved
@bjoernricks
Improve make_unique deprecation warning test
c496c8e 
Check if the warning is raised.
wiegandm
wiegandm approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@wiegandm wiegandm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bjoernricks bjoernricks merged commit 1f49d71 into greenbone:master Sep 19, 2019
@bjoernricks bjoernricks deleted the deprecate-make-unique branch September 19, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiegandm wiegandm wiegandm approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @wiegandm