Adding GMPv9 functionality to python-gvm #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernricks
suggested changes
Sep 23, 2019
|
The EntityType should be extended to support tls certificates too. E.g it must be possible to create tags and filter for tls certs. |
bjoernricks
suggested changes
Sep 24, 2019
bjoernricks
suggested changes
Sep 25, 2019
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
| * Added `usage_type` `scan` to `create_task` method [PR 157](https://github.com/greenbone/python-gvm/pull/157) |
There was a problem hiding this comment.
Suggested change
| * Added `usage_type` `scan` to `create_task` method [PR 157](https://github.com/greenbone/python-gvm/pull/157) |
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
| * Added `usage_type` `scan` to `create_task` method [PR 157](https://github.com/greenbone/python-gvm/pull/157) | ||
| * Added `usage_type` `scan` to `create_config` method [PR 157](https://github.com/greenbone/python-gvm/pull/157) |
There was a problem hiding this comment.
Suggested change
| * Added `usage_type` `scan` to `create_config` method [PR 157](https://github.com/greenbone/python-gvm/pull/157) |
bjoernricks
approved these changes
Sep 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 90.94% 91.33% +0.38%
==========================================
Files 11 12 +1
Lines 906 1015 +109
==========================================
+ Hits 824 927 +103
- Misses 82 88 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding GMPv9 functionality to python-gvm.
Checklist: